Skip to content

Conversation

@klamike
Copy link
Collaborator

@klamike klamike commented Mar 25, 2025

No description provided.

@klamike klamike requested a review from andrewrosemberg March 25, 2025 14:04
Copy link
Member

@andrewrosemberg andrewrosemberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klamike
Copy link
Collaborator Author

klamike commented Mar 25, 2025

@andrewrosemberg is that CI failure expected?

@andrewrosemberg
Copy link
Member

It seems to be a breaking change from one of the dependencies (probably Flux) that now exports gradient:

WARNING: both Flux and Zygote export "gradient"; uses of it in module LearningToOptimize must be qualified

We should qualify it in

∇model, _ = gradient(model, d...) do m, x, y # calculate the gradients

If you don't want to do it here, I can do it in a subsequent PR

@klamike klamike merged commit d3c799f into main Mar 27, 2025
2 checks passed
@klamike klamike deleted the mk/typo branch March 27, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants